Add WARN log if provided Couchbase password offends default policy#936
Merged
Add WARN log if provided Couchbase password offends default policy#936
Conversation
rnorth
reviewed
Oct 28, 2018
modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseContainer.java
Outdated
Show resolved
Hide resolved
rnorth
approved these changes
Oct 28, 2018
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
I think this looks fine, really. It provides potentially useful information without breaking things with an exception if people have changed their policy.
👍 to merge if you could maybe tweak the warning message string 😄
…ouchbaseContainer.java Co-Authored-By: kiview <kiview@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #934
TBH I was not sure how to proceed at this point. We have a similar password policy thing in #885.
However, throwing an exception seems to harsh, since people might configure all kind of password policies in their image (I assume) and we should still support it if possible.