Feat/docker engine api client#17
Merged
shyim merged 30 commits intotestcontainers:0.2from Oct 1, 2024
Merged
Conversation
…containers language packages
… implementation instead.
… some code duplication. Adjust Postgres test
… class - Added random port logic - Updated wait wtrategies - API alignments to make it similar to other official implementations - ...
shyim
reviewed
Sep 7, 2024
rw4lll
changed the title
Fixes and improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
Testcontainerslibrary, focusing on refactoring container classes and updating the documentation. The most important changes include the deprecation of theContainerclass in favor ofGenericContainer, updates to theREADME.mdto reflect these changes, and modifications to thecomposer.jsonfile to include new dependencies.Code Refactoring:
src/Container/Container.php: Deprecated theContainerclass and redirected its functionality toGenericContainer. Added methods for backward compatibility and marked them as deprecated.src/Container/GenericContainer.php: Introduced a newGenericContainerclass with enhanced functionality and better structuring.src/Container/MariaDBContainer.php: Deprecated theMariaDBContainerclass in favor of\Testcontainers\Modules\MariaDBContainer.Documentation Updates:
README.md: Updated examples to useGenericContainerand other module-specific containers likeMySQLContainerandRedisContainer. [1] [2] [3] [4] [5] [6] [7]Dependency Management:
composer.json: Added new dependenciesbeluga-php/docker-phpandsymfony/http-client. Includedext-curlandext-pdoin therequire-devsection. Updated theallow-pluginsconfiguration. [1] [2]