add withHostname, withName, withLabels support#24
Merged
shyim merged 2 commits intotestcontainers:0.2from Dec 29, 2024
Merged
Conversation
shyim
approved these changes
Dec 29, 2024
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/Containerdirectory, primarily focusing on enhancing theGenericContainerclass and removing deprecated methods. The most important changes include the addition of new properties and methods to manage container metadata and the removal of a deprecated method from theContainerclass.Enhancements to
GenericContainerclass:src/Container/GenericContainer.php: Added new propertiesname,labels, andhostnameto manage container metadata.src/Container/GenericContainer.php: Added methodswithHostname,withName, andwithLabelsto set the newly added properties. [1] [2]src/Container/GenericContainer.php: Updated thestartmethod to includenamein the query parameters when creating a container.src/Container/GenericContainer.php: Updated thecreateContainerConfigmethod to set thelabelsandhostnameproperties in the container configuration.Removal of deprecated method:
src/Container/Container.php: Removed the deprecatedwithHostnamemethod.