test: remove duplicate cases#927
Merged
Belco90 merged 1 commit intotesting-library:mainfrom Oct 17, 2024
G-Rath:remove-duplicate-cases
Merged
test: remove duplicate cases#927Belco90 merged 1 commit intotesting-library:mainfrom G-Rath:remove-duplicate-cases
Belco90 merged 1 commit intotesting-library:mainfrom
G-Rath:remove-duplicate-cases
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
==========================================
+ Coverage 96.23% 96.32% +0.08%
==========================================
Files 44 44
Lines 2419 2449 +30
Branches 1000 1023 +23
==========================================
+ Hits 2328 2359 +31
+ Misses 91 90 -1 ☔ View full report in Codecov by Sentry. |
1 task
MichaelDeBoey
approved these changes
Oct 16, 2024
Belco90
approved these changes
Oct 17, 2024
|
🎉 This PR is included in version 6.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
Context
ESLint v9 now errors about duplicate test cases, meaning these have to be either removed or made unique - all of the cases being removed in this pull request are flat out code duplicates hence their removal; there are still other duplicates that will need addressing, but they're a little more fuzzy so I will tackle them in another pull request.
(this helps reduce the diff for #926 and friends)