-
Notifications
You must be signed in to change notification settings - Fork 17
first stab at defining a mechanism for extension jars #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
antoinell
wants to merge
20
commits into
testingisdocumenting:master
Choose a base branch
from
antoinell:znai-extensibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
first stab at defining a mechanism for extension jars #1394
antoinell
wants to merge
20
commits into
testingisdocumenting:master
from
antoinell:znai-extensibility
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the reason is to indirectly bump net.minidev:json-smart to 2.6.0. We currently have this dependency tree : +- com.jayway.jsonpath:json-path:jar:2.9.0:compile | +- net.minidev:json-smart:jar:2.5.0:runtime There is a vulnerability, see https://www.mend.io/vulnerability-database/CVE-2024-57699?utm_source=JetBrains
Contributor
Author
|
Adding this in the html before all the javascripts helps to resolve react The extra css should also be in a separate resource file as the code to load css is different. |
…ferent from just a module with the react chunks.
antoinell
commented
Jan 6, 2026
| mode: 'automatic' | ||
| }, | ||
| logLevel: 'debug', | ||
| preserveEntrySignatures: 'strict', |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #1393
demonstration repository : https://github.com/antoinell/znai-quizzes
That is not yet working, the demo app is not yet able to display the quiz and is displaying errors in the JavaScript console
I expect to be solving this in the next few days.