Retry analyzer not calling BeforeMethod & AfterMethods if firstTimeOnly/lastTimeOnly are mentioned for the test

[narulacool]

Consider the case below:

@BeforeMethod(firstTimeOnly=true)
public void StartDriver()
{
   System.out.println("Start Driver");
}

@AfterMethod(lastTimeOnly=true)
public void stopDriver()
{
   System.out.println("Stop Driver");
}

@Test
public void TestRetry()
{
   Assert.assertTrue(false,"TestRetry Failed");
}

If I use TestNG's IRetryAnalyzer to rerun the above case, the StartDriver & stopDriver are called for the actual first run, while none of the two is called for the Second(retry) time.

[testng] Start Driver
[testng] [Status]:TestRetry2_FAIL
[testng] Stop Driver
[testng] Going to retry test case: TestRetry()
[testng] [Status]:TestRetry2_FAIL

I am using TestNG 6.9.4 & this works fine(i.e start & stop are called for both first time & for the retry execution) if firstTimeOnly & lastTimeOnly are not mentioned.

Any help would be deeply appreciated.

[narulacool]

ping..

[prvn133t]

I guess this is working as designed. Looking at the code of public boolean firstTimeOnly() default false;

I see

If true and the @test method about to be run has an invocationCount > 1, this
BeforeMethod will only be invoked once (before the first test invocation).

So the invocationCount is already > 1 during the retry. So this is working as expected.

So your best bet would be not to use firstTimeOnly

[rschmitt]

It does, however, look like the @AfterMethod is being called prematurely.

[prvn133t]

@rschmitt : Do you have a test? I can debug the code.

P.S : @AfterMethod is outside the scope of this issue

[rschmitt]

Says who? Look at his console output again:

[testng] Start Driver
[testng] [Status]:TestRetry2_FAIL
[testng] Stop Driver
[testng] Going to retry test case: TestRetry()
[testng] [Status]:TestRetry2_FAIL

It's an invariant violation for the @AfterMethod here to run between tests, isn't it?

[prvn133t]

@rschmitt : I totally agree what you're saying. All I'm saying is, this defect context doesn't reflect the actual bug in testng.

There should be a new defect for "Retry analyzer not calling BeforeMethod & AfterMethods if it's specified in a Test Class"

Example :

public class testBug {

@BeforeMethod()
public void StartDriver()
{
   System.out.println("Start Driver");
}

@AfterMethod()
public void stopDriver()
{
   System.out.println("Stop Driver");
}

@Test
public void TestRetry()
{
   Assert.assertTrue(false,"TestRetry Failed");
}

Now this won't call BeforeMethod and AfterMethod During 'RetryAnalyzer`