Make model association step more idiomatic#57
Open
morenoh149 wants to merge 1 commit intothe-road-to-graphql:masterfrom
Open
Make model association step more idiomatic#57morenoh149 wants to merge 1 commit intothe-road-to-graphql:masterfrom
morenoh149 wants to merge 1 commit intothe-road-to-graphql:masterfrom
Conversation
* use Object.values to get a more meaningful `model` var and associate it if it has an associate field.
|
Another variant, bit more "functional" : Object.values(models)
.filter(model => typeof model.associate === 'function')
.forEach(model => model.associate(models)); |
Contributor
Author
|
@Sharlaan I also considered Object.values(models)
.filter(model => model.associate)
.forEach(model => model.associate(models));and Object.values(models).forEach(model => model.associate && model.associate(models));but I preferred my proposal as most understandable. |
Member
|
Thanks for the input! I will take this into account once I write a new version for the tutorial 🚀 Given that it will take some time, please leave your suggestions here on how to make it more idiomatic! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modelvar and associate it if it has an associate field.