fdi.ssh=1 enables root login & passwd auth#178
Merged
stejskalleos merged 1 commit intomasterfrom Feb 5, 2026
Merged
Conversation
8 tasks
evgeni
reviewed
Feb 5, 2026
evgeni
reviewed
Feb 5, 2026
|
|
||
| { | ||
| echo '#FDI' | ||
| echo "PubkeyAuthentication yes" |
Contributor
Author
There was a problem hiding this comment.
However, I'm not sure if anyone is doing that.
Member
|
Given both sed -i '/^PermitRootLogin/d' /etc/ssh/sshd_config
echo 'PermitRootLogin yes' >> /etc/ssh/sshd_configBut I am fine if you want to explicitly set the others. |
Contributor
Author
I'd like to explicitly do that, it's clear what we do (and what we need) without looking for the default |
evgeni
reviewed
Feb 5, 2026
| KEYS=("PubkeyAuthentication" "PasswordAuthentication" "PermitRootLogin") | ||
|
|
||
| for KEY in "${KEYS[@]}"; do | ||
| sed -i "/^#\?${KEY}/d" "/etc/ssh/sshd_config" |
Member
There was a problem hiding this comment.
Suggested change
| sed -i "/^#\?${KEY}/d" "/etc/ssh/sshd_config" | |
| sed -i "/^${KEY}/d" "/etc/ssh/sshd_config" |
We don't need to delete comments.
evgeni
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Adding
fdi.ssh=1 fdi.rootpw=changemeto kernel attributes will enable thesshdservice, but it won't allow root login to authenticate.Now
Adding
fdi.ssh=1will enable root login and password authentication for the root user.Notes:
fdi.ssh=truedoesn't work; the documentation is incorrect. See theforeman/foreman-documentation#4635