Skip to content

Add 'attribute' content type#4631

Merged
aneta-petrova merged 1 commit intotheforeman:masterfrom
aneta-petrova:dita-attribute
Feb 13, 2026
Merged

Add 'attribute' content type#4631
aneta-petrova merged 1 commit intotheforeman:masterfrom
aneta-petrova:dita-attribute

Conversation

@aneta-petrova
Copy link
Member

What changes are you introducing?

Adding the attribute content type to all attribute files.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

asciidoctor-dita-vale relies on the attribute to recognize attribute files

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 3, 2026
@aneta-petrova aneta-petrova removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

The PR preview for bdc8667 is available at theforeman-foreman-documentation-preview-pr-4631.surge.sh

No diff compared to the current base

show diff

@aneta-petrova aneta-petrova marked this pull request as ready for review February 11, 2026 12:14
@aneta-petrova
Copy link
Member Author

Ready for review.

No diff compared to the current base

This tells me adding this particular content attribute doesn't affect anything.

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb maximiliankolb added the style review done No issues from docs style/grammar perspective label Feb 11, 2026
@aneta-petrova aneta-petrova merged commit 4f24328 into theforeman:master Feb 13, 2026
11 checks passed
@aneta-petrova aneta-petrova deleted the dita-attribute branch February 13, 2026 14:46
aneta-petrova added a commit that referenced this pull request Feb 13, 2026
(cherry picked from commit 4f24328)
aneta-petrova added a commit that referenced this pull request Feb 13, 2026
(cherry picked from commit 4f24328)
aneta-petrova added a commit that referenced this pull request Feb 13, 2026
(cherry picked from commit 4f24328)
@aneta-petrova
Copy link
Member Author

aneta-petrova commented Feb 13, 2026

Merged to "master" and cherry-picked:

111f011..d624eea 3.18 -> 3.18
f87e34c..15d0fd7 3.17 -> 3.17 (minor conflict, due to some attr files not being present)
b68d3c4..6984157 3.16 -> 3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants