Use retain version only with additive mirroring#4653
Merged
aneta-petrova merged 2 commits intotheforeman:masterfrom Feb 17, 2026
Merged
Use retain version only with additive mirroring#4653aneta-petrova merged 2 commits intotheforeman:masterfrom
aneta-petrova merged 2 commits intotheforeman:masterfrom
Conversation
github-actions
bot
added
Needs tech review
|
The PR preview for e0d1308 is available at theforeman-foreman-documentation-preview-pr-4653.surge.sh The following output files are affected by this PR: |
guides/common/modules/proc_adding-custom-rpm-repositories-by-using-web-ui.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com>
aneta-petrova
approved these changes
Feb 17, 2026
aneta-petrova
added
style review done
Member
|
Normally a tech review from another engineer would be required but because this update does not significantly change description of product behavior, I believe we can skip this. |
aneta-petrova
added
tech review done
aneta-petrova
added a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com> (cherry picked from commit 35fde0d)
aneta-petrova
added a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com> (cherry picked from commit 35fde0d)
aneta-petrova
added a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com> (cherry picked from commit 35fde0d)
aneta-petrova
added a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com> (cherry picked from commit 35fde0d)
aneta-petrova
added a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com> (cherry picked from commit 35fde0d)
aneta-petrova
added a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com> (cherry picked from commit 35fde0d)
aneta-petrova
added a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Aneta Šteflová Petrová <apetrova@redhat.com> (cherry picked from commit 35fde0d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Adds a note that the retain versions field is only to be used with the additive download policy.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
The retain versions feature is only possible if using the additive mirroring policy.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I wasn't sure if it was worth explicitly mentioning that the retain versions field disappears in the UI if the additive mirroring policy is not selected.
Contributor checklists
Please cherry-pick my commits into: