Add snippet content type (#4626)#4655
Merged
aneta-petrova merged 2 commits intotheforeman:3.17from Feb 16, 2026
Merged
Conversation
github-actions
bot
added
Needs tech review
aneta-petrova
removed
Needs tech review
aneta-petrova
force-pushed
the
mod-docs-snippet-3-17
branch
2 times, most recently
from
31d684c to
7596a4a
Compare
Includes most of the changes from cfe820e
Add '+' Update module type Add snip content type to repo configuration procedures
aneta-petrova
force-pushed
the
mod-docs-snippet-3-17
branch
from
95a1e0d to
cb8778c
Compare
Member
Author
|
Hi @maximiliankolb, can you please review? The first commit contains the same changes as #4626, excluding changes to some files that did not fit the 3.17 branch well. So after excluding those files, I applied the SNIPPET type manually in them and resolved any issues that occurred. The HTML diff doesn't show any |
aneta-petrova
added
the
Needs style review
aneta-petrova
added
style review done
Member
Author
|
I'll merge without waiting for 24 hours because this is still for the most part just a cherry-pick. |
Member
Author
|
Merged to "3.17" but I'll need yet another PR for "3.16" because a few procedures in the security compliance guide got broken by adding the attribute. |
aneta-petrova
added a commit
to aneta-petrova/foreman-documentation
that referenced
this pull request
Feb 16, 2026
9 tasks
aneta-petrova
added a commit
that referenced
this pull request
Feb 16, 2026
* Add snippet content type (#4626) (#4655) * Add snippet content type Includes most of the changes from cfe820e * Apply adjustments after adding SNIPPET content type Add '+' Update module type Add snip content type to repo configuration procedures (cherry picked from commit 53677c1) * Drop a snippet that doesn't work well with content type attr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Changes from cfe820e. Most of them were fine (just adding the SNIPPET content type and
+to make sure procedures don't get broken), but it was mostly the repository configuration procedures that needed scratching the original changes and just re-applying the content type again.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
An attempt to apply #4626 to branch 3.17
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: