Skip to content

Fixes #13712 - seed power action templates#155

Merged
iNecas merged 1 commit intotheforeman:masterfrom
iNecas:power-actions
Feb 17, 2016
Merged

Fixes #13712 - seed power action templates#155
iNecas merged 1 commit intotheforeman:masterfrom
iNecas:power-actions

Conversation

@iNecas
Copy link
Copy Markdown
Member

@iNecas iNecas commented Feb 12, 2016

No description provided.

required: true
%>

echo <%= input('action') %> host && sleep 3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a sleep? Also is host available or should it be @host?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To give it a time to get the last output from the connection: we need the echo message to be received by the proxy (so that we know the disconnection is expected) before we loose the connection (and we can say that the disconnection error was expected, and not fail the whole script)

@ares
Copy link
Copy Markdown
Member

ares commented Feb 15, 2016

Please, create a separate issue for this

@iNecas iNecas changed the title refs #13491 - seed power action templates refs #13712 - seed power action templates Feb 15, 2016
@iNecas
Copy link
Copy Markdown
Member Author

iNecas commented Feb 15, 2016

@ares
Copy link
Copy Markdown
Member

ares commented Feb 15, 2016

Thanks, could you please change the commit message to Fixes? I think refs only links commit but does not close the issue.

@ares
Copy link
Copy Markdown
Member

ares commented Feb 15, 2016

Otherwise 👍

@ares
Copy link
Copy Markdown
Member

ares commented Feb 16, 2016

commit message links to different issue 13491 -> 13712

@iNecas
Copy link
Copy Markdown
Member Author

iNecas commented Feb 16, 2016

Thanks for the catch: an issue between chair and 💻, updated

iNecas added a commit that referenced this pull request Feb 17, 2016
Fixes #13712 - seed power action templates
@iNecas iNecas merged commit c8212b5 into theforeman:master Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants