Conversation
|
No blocks from our side |
|
@Zethson since you created the issue; was this specifically about using |
I think we can go with this. Don't need to support the old format |
|
Hmm I had unpinned it before and ran into a test error back then. Surprised it works now but ok |
|
@eroell the tests used the cached environment. This shouldn't be the case right? |
|
Also, if you check the notebooks jobs:
|
… disable chunks arg in write_zarr
|
If I think the new appearance of this error has to do with multiple more recent packages being used now that the I became suspicious as well whether lamindb_setup's pin to Since |
That package provides the also even if you remove the |
Indeed, I have the suspicion that along the dependency tree of vitessce a pin could exist? Since there were not actively maintained packages included too, I stopped digging at one point.. |
OK! I'll add this again then |
|
It’s really easy, I just added an lower bound to Also you let your docs degrade by not running it with
Most of these should have been fixed when they were introduced (except for the zarr stuff, which makes sense to be fixed in this PR) |
| path: Path | None = None, | ||
| *, | ||
| store: Path | Store | None = None, | ||
| store: Path | StoreLike | None = None, |
There was a problem hiding this comment.
I actually don’t know if vitessce takes a StoreLike or only a real zarr.abc.store.Store.
If the latter, than the import should be changed.
🤯 |
|
Ah sorry, lower bound! Don’t do upper bounds, this was just a typo. |
Yes I got it, the exploding head was regarding how quickly you fixed that |
flying-sheep
left a comment
There was a problem hiding this comment.
Looks good except for that nasty implicit state change on import!
Let’s wait for the discussion in scverse/anndata#2193 also!
|
I changed a final thing here:
|
Closes #170.
An optional dependency (vitessce-python) is still requiring
zarr<3though, zarr v3 is an open issue vitessce/vitessce-python#481