Skip to content

Fix for unintentional filename conflicts within raw_models in streaming#120

Merged
thelink2012 merged 4 commits into
thelink2012:masterfrom
rokuniichi:raw_models_fix
Apr 26, 2026
Merged

Fix for unintentional filename conflicts within raw_models in streaming#120
thelink2012 merged 4 commits into
thelink2012:masterfrom
rokuniichi:raw_models_fix

Conversation

@rokuniichi

Copy link
Copy Markdown
Contributor

Solution for this issue:
#119

Same basename in different .img paths no longer overwrites earlier entries. Look up and remove with equal_range/find_if instead of linear scan or erase-by-key.
@thelink2012

thelink2012 commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Thanks @rokuniichi and sorry for the late review.

I have replaced the std::map<filepath, ...> because during the non-streaming search it'd do O(n) lookups with std::find_if. As a replacement solution, I am moving off std::map<filename, ...> to std::multimap<filename, ...>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants