Fixes widget clipping issue#148
Merged
thepeacemonk merged 2 commits intothepeacemonk:mainfrom Feb 18, 2026
Merged
Conversation
Solves one of the issues with some external add-ons being clipped from the top.
Fixes widget clipping issue
Contributor
Author
|
Not sure why it made two commits, sorry about that. New to contributing on GitHub 😅 |
Owner
|
Hi there @gbk757 Thanks for the PR! I'll analyze it and consider it for our next update, appreciate your time for doing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves one of the issues with some external add-ons being clipped from the top. I tested it with only two add-ons to ensure it fixed the problem. It doesn't seem to have a significant impact on properly working external add-ons other than creating more space between widgets. Didn't affect built-in widgets at all when testing.
Complete (temp?) Fix:
#131 - Should be fully resolved now.
Partial Fix:
#8 - Unfortunately, doesn't fix every problem with this issue. Parts of some widgets are still completely missing, while others don't work at all. However, spacing did slightly improve usability for "problem add-ons."
Before example:
After example:
It took a lot of trial and error to see if anything would fix it and not make styling even worse. This was the best option I could find. All it does is add one "justify" line in "onigiri_renderer.py". That lets "div.external-widget-container" to center the add-on.
NOTE: Depending on how much of the add-on got clipped, more rows need to be given to the add-on in Widget Grid settings. if you give it 4 rows, it ends up treating all 4 rows as one block and centering between rows 2 and 3.