-
Notifications
You must be signed in to change notification settings - Fork 350
Tools: Topology: Add sof-ptl-rt722-4ch-ssp2bt-echoref #10486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tools: Topology: Add sof-ptl-rt722-4ch-ssp2bt-echoref #10486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for a new topology configuration that includes SSP2 Bluetooth functionality with echo reference capabilities, based on the existing sof-ptl-rt722-4ch-echoref topology.
Changes:
- Added new topology target
sof-ptl-rt722-4ch-ssp2bt-echorefwith SSP2 BT and echo reference support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@singalsu Im wondering if this is the right fix for the error we see with missing DAI link. Why does the machine driver create the BT DAI link in the first place? Is the machine quirk for BT_PRESENT set? Can we override this with our module params to disable the bt_link_mask? |
@singalsu this fix is good. The NHLT is reporting the present of the BT link, so the topology should include it as well. Thanks! |
Support for SSP2 BT with echo reference is included in topology. The topology is otherwise similar as sof-ptl-rt722-4ch-echoref. Signed-off-by: Seppo Ingalsuo <[email protected]>
ad5b43e to
0b8296e
Compare
|
I fixed duplicate NHLT_BIN name, now it is nhlt-sof-ptl-rt722-4ch-ssp2bt-echoref.bin. |
@singalsu we dont need this change anymore. I have fixed the issue in the kernel. see thesofproject/linux#5650 |
ranj063
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed
Support for SSP2 BT with echo reference is included in topology. The topology is otherwise similar as
sof-ptl-rt722-4ch-echoref.