-
Notifications
You must be signed in to change notification settings - Fork 357
acp: add native Zephyr drivers for AMD ACP 7.X #10777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f7c7956
0ddd1d4
de2b148
d24bafc
9040080
2be9e8b
8cc4ed0
c0867a5
d52f73f
75dcc90
48685cb
686cb0d
03cf70b
b22582f
e57b2d7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| CONFIG_ACP_7_X=y | ||
| CONFIG_HAVE_AGENT=n | ||
| CONFIG_DCACHE_LINE_SIZE_DETECT=n | ||
| CONFIG_DCACHE_LINE_SIZE=128 | ||
| CONFIG_DYNAMIC_INTERRUPTS=y | ||
| CONFIG_SHARED_INTERRUPTS=n | ||
| CONFIG_ZEPHYR_LOG=y | ||
| CONFIG_LOG_MODE_DEFERRED=n | ||
| CONFIG_LOG_MODE_MINIMAL=y | ||
| CONFIG_DMA=y | ||
| CONFIG_DMA_DOMAIN=n | ||
| CONFIG_ZEPHYR_NATIVE_DRIVERS=y | ||
| CONFIG_INTC_AMD_ACP=y | ||
| CONFIG_DMA_AMD_ACP_HOST=y | ||
| CONFIG_DMA_AMD_ACP_SDW=y | ||
| CONFIG_DMA_AMD_ACP_SDW_CHANNEL_COUNT=64 | ||
| CONFIG_DAI_AMD_SDW=y | ||
| CONFIG_AMS=n | ||
| CONFIG_WRAP_ACTUAL_POSITION=y | ||
| CONFIG_TRACE=n | ||
| CONFIG_COMP_VOLUME=y | ||
| CONFIG_COMP_SRC=n | ||
| CONFIG_COMP_FIR=n | ||
| CONFIG_COMP_IIR=n | ||
| CONFIG_COMP_DCBLOCK=n | ||
| CONFIG_COMP_CROSSOVER=n | ||
| CONFIG_COMP_DRC=n | ||
| CONFIG_COMP_MULTIBAND_DRC=n | ||
| CONFIG_COMP_TONE=n | ||
| CONFIG_COMP_KPB=n | ||
| CONFIG_MAXIM_DSM=n | ||
| CONFIG_COMP_ASRC=n | ||
| CONFIG_COMP_IGO_NR=n | ||
| CONFIG_COMP_COPIER=n | ||
| CONFIG_COMP_RTNR=n | ||
| CONFIG_COMP_ARIA=n | ||
| CONFIG_COMP_BASEFW_IPC4=n | ||
| CONFIG_COMP_UP_DOWN_MIXER=n | ||
| CONFIG_COMP_TDFB=n | ||
| CONFIG_COMP_SEL=n | ||
| CONFIG_COMP_MIXER=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_24000_TO_08000=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_24000_TO_16000=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_08000=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_11025=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_12000=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_16000=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_22050=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_24000=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_32000=n | ||
| CONFIG_ASRC_SUPPORT_CONVERSION_48000_TO_44100=n | ||
| CONFIG_CORE_COUNT=1 | ||
| CONFIG_FORMAT_CONVERT_HIFI3=n | ||
| CONFIG_PCM_CONVERTER_FORMAT_S24_4LE_MSB=y | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,6 +117,13 @@ class PlatformConfig: | |
| "ACP_7_0_HiFi5_NNE_PROD", | ||
| RIMAGE_KEY = "key param ignored by acp_7_0" | ||
| ), | ||
| "acp_7_x" : PlatformConfig( | ||
| "amd", "acp_7_x_adsp/acp_7_x", | ||
| f"RI-2022.9{xtensa_tools_version_postfix}", | ||
| "ACP73x_HiFi5_NNE_PROD", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in latest push. |
||
| RIMAGE_KEY = "key param ignored by acp_7_x", | ||
| aliases = ["acp7x"] | ||
| ), | ||
| # MediaTek platforms | ||
| # (move to platform_configs_all on next Zephyr SDK release after 0.17.0) | ||
| "mt8195" : PlatformConfig( | ||
|
|
@@ -1324,7 +1331,7 @@ def gzip_compress(fname, gzdst=None): | |
| RI_INFO_UNSUPPORTED = [] | ||
|
|
||
| RI_INFO_UNSUPPORTED += ['imx8', 'imx8x', 'imx8m', 'imx8m_cm7', 'imx8ulp', 'imx95'] | ||
| RI_INFO_UNSUPPORTED += ['rn', 'acp_6_0', 'acp_7_0'] | ||
| RI_INFO_UNSUPPORTED += ['rn', 'acp_6_0', 'acp_7_0', 'acp_7_x'] | ||
| RI_INFO_UNSUPPORTED += ['mt8186', 'mt8188', 'mt8195', 'mt8196', 'mt8365'] | ||
| RI_INFO_UNSUPPORTED += ['qemu_xtensa', 'qemu_xtensa_mmu'] | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| CONFIG_ACP_7_X=y | ||
| CONFIG_RIMAGE_SIGNING_SCHEMA="acp_7_3" | ||
| CONFIG_TRACE_CHANNEL=7 | ||
| CONFIG_WRAP_ACTUAL_POSITION=y | ||
| CONFIG_CORE_COUNT=1 | ||
| CONFIG_FORMAT_CONVERT_HIFI3=n | ||
| CONFIG_LP_SRAM=n | ||
| CONFIG_HAVE_AGENT=n | ||
| CONFIG_COMP_VOLUME=y | ||
|
kv2019i marked this conversation as resolved.
|
||
| CONFIG_COMP_SRC=n | ||
| CONFIG_COMP_FIR=n | ||
| CONFIG_COMP_IIR=n | ||
| CONFIG_COMP_DCBLOCK=n | ||
| CONFIG_COMP_CROSSOVER=n | ||
| CONFIG_COMP_DRC=n | ||
| CONFIG_COMP_MULTIBAND_DRC=n | ||
| CONFIG_COMP_TONE=n | ||
| CONFIG_COMP_SWITCH=n | ||
| CONFIG_COMP_KPB=n | ||
| CONFIG_MAXIM_DSM=n | ||
| CONFIG_COMP_ASRC=n | ||
| CONFIG_COMP_IGO_NR=n | ||
| CONFIG_COMP_COPIER=n | ||
| CONFIG_COMP_RTNR=n | ||
| CONFIG_COMP_ARIA=n | ||
| CONFIG_COMP_BASEFW_IPC4=n | ||
| CONFIG_COMP_UP_DOWN_MIXER=n | ||
| CONFIG_COMP_TDFB=n | ||
| CONFIG_COMP_MUX=n | ||
| CONFIG_COMP_SEL=n | ||
| CONFIG_COMP_MIXER=n | ||
| CONFIG_PROBE=n | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -715,6 +715,10 @@ const struct pcm_func_map pcm_func_map[] = { | |
| { SOF_IPC_FRAME_S24_4LE, SOF_IPC_FRAME_S32_LE, pcm_convert_s24_to_s32 }, | ||
| { SOF_IPC_FRAME_S32_LE, SOF_IPC_FRAME_S24_4LE, pcm_convert_s32_to_s24 }, | ||
| #endif /* CONFIG_PCM_CONVERTER_FORMAT_S32LE && CONFIG_PCM_CONVERTER_FORMAT_S24LE */ | ||
| #if CONFIG_PCM_CONVERTER_FORMAT_S32LE && CONFIG_PCM_CONVERTER_FORMAT_S24_4LE_MSB | ||
| { SOF_IPC_FRAME_S32_LE, SOF_IPC_FRAME_S24_4LE_MSB, pcm_convert_s32_to_s24_be }, | ||
| { SOF_IPC_FRAME_S24_4LE_MSB, SOF_IPC_FRAME_S32_LE, just_copy }, | ||
| #endif /* CONFIG_PCM_CONVERTER_FORMAT_S32LE && CONFIG_PCM_CONVERTER_FORMAT_S24_4LE_MSB */ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ack, this looks good now, thanks! |
||
| #if CONFIG_PCM_CONVERTER_FORMAT_FLOAT | ||
| { SOF_IPC_FRAME_FLOAT, SOF_IPC_FRAME_FLOAT, just_copy }, | ||
| #endif /* CONFIG_PCM_CONVERTER_FORMAT_FLOAT */ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,13 @@ | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
| add_subdirectory(common) | ||
| if(CONFIG_RENOIR OR CONFIG_VANGOGH OR CONFIG_REMBRANDT OR CONFIG_ACP_6_3 OR CONFIG_ACP_7_0) | ||
| add_subdirectory(common) | ||
| endif() | ||
| if(CONFIG_RENOIR) | ||
| add_subdirectory(renoir) | ||
| elseif(CONFIG_REMBRANDT OR CONFIG_ACP_6_3 OR CONFIG_ACP_7_0) | ||
| add_subdirectory(rembrandt) | ||
| elseif(CONFIG_VANGOGH) | ||
| add_subdirectory(vangogh) | ||
| elseif(CONFIG_ACP_7_X) | ||
| add_subdirectory(acp_7_x) | ||
| endif() |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| add_local_sources(sof | ||
| ipc.c | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please separate baord specific board file change to a separate git commit from the generic change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kv2019i.
changed as suggested in latest push.