audio: asrc: fix runtime params validation#10803
Open
wjablon1 wants to merge 1 commit into
Open
Conversation
wjablon1
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes incorrect runtime PCM rate validation in the ASRC module by making stream-parameter validation IPC-protocol specific, avoiding bogus errors for IPC4 where the runtime params rate is not mode-dependent (PULL/PUSH) in the same way as IPC3.
Changes:
- Split ASRC stream params verification into
asrc_verify_stream_params()with IPC3/IPC4-specific implementations. - Update ASRC params handling to call the new verification function and keep buffer parameter verification (
comp_verify_params) inasrc.c. - Add the new verification function prototype to the ASRC public header.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/audio/asrc/asrc.h | Adds the asrc_verify_stream_params() declaration used by the common ASRC params path. |
| src/audio/asrc/asrc.c | Replaces the old monolithic verification with IPC-specific verification + comp_verify_params(). |
| src/audio/asrc/asrc_ipc4.c | Implements IPC4 verification as a no-op to avoid mode-dependent false failures. |
| src/audio/asrc/asrc_ipc3.c | Moves the mode-dependent PCM rate validation logic into the IPC3-specific implementation. |
softwarecki
approved these changes
May 25, 2026
serhiy-katsyuba-intel
approved these changes
May 25, 2026
kv2019i
requested changes
May 25, 2026
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
The IPC3 variant doesn't build after the changes:
https://github.com/thesofproject/sof/actions/runs/26281359601/job/77358062049?pr=10803
IPC4 params do not provide a PCM sampling rate that is dynamically selected based on the mode (PULL/PUSH). Instead, the received params contain only a copy of the source rate already stored in ipc4_asrc_module_cfg. As a result, mode-dependent validation can trigger a bogus error. Fix this by splitting params validation into IPC protocol-specific functions. Signed-off-by: Wojciech Jablonski <wojciech.jablonski@intel.com>
wjablon1
force-pushed
the
asrc_rate_val_fix
branch
from
ccad2ba to
fc757b0
Compare
Contributor
Author
|
@kv2019i IPC3 builds fixed, thanks |
tmleman
reviewed
May 25, 2026
Comment on lines
+84
to
+86
| */ | ||
| ARG_UNUSED(mod); | ||
| ARG_UNUSED(params); |
Contributor
There was a problem hiding this comment.
Remember also about testbench: https://github.com/thesofproject/sof/actions/runs/26401755902/job/77715479520?pr=10803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPC4 params do not provide a PCM sampling rate that is dynamically selected based on the mode (PULL/PUSH). Instead, the received params contain only a copy of the source rate already stored in ipc4_asrc_module_cfg. As a result, mode-dependent validation can trigger a bogus error. Fix this by splitting params validation into IPC protocol-specific functions.