make copyable corners open in a new tab by default#50
Closed
hamirmahal wants to merge 1 commit intotholman:masterfrom
hamirmahal:feat/make-corners-open-in-new-tabs-by-default
Closed
make copyable corners open in a new tab by default#50hamirmahal wants to merge 1 commit intotholman:masterfrom hamirmahal:feat/make-corners-open-in-new-tabs-by-default
hamirmahal wants to merge 1 commit intotholman:masterfrom
hamirmahal:feat/make-corners-open-in-new-tabs-by-default
Conversation
Author
|
@tholman what changes would you like to see to this pull request before merging it? |
Owner
|
Hey mate, Yeah I'd rather leave this as something that people can add rather than something they'd need to take away. |
Author
|
That makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would be nice if GitHub corners opened their links in a new tab by default.
This pull request proposes an update to the ten
<textarea>s at https://tholman.com/github-corners/ so they contain GitHub corners that will open in a new tab by default.Hope it helps!
Update: I created #51 to track this issue. This pull request closes #51 if we merge it.