Skip to content

fix: update ExternalCancellationTests documentation and add ExcludeOn attribute for Windows #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Dec 11, 2025
Merged

fix: update ExternalCancellationTests documentation and add ExcludeOn attribute for Windows #4059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions TUnit.Engine.Tests/ExternalCancellationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Diagnostics;
using CliWrap;
using Shouldly;
using TUnit.Core.Enums;
using TUnit.Engine.Tests.Enums;

namespace TUnit.Engine.Tests;
Expand All @@ -10,6 +11,12 @@ namespace TUnit.Engine.Tests;
/// These tests start the test process asynchronously, cancel it mid-execution (simulating Ctrl+C or Stop button),
/// and verify that After hooks still execute by checking for marker files.
/// </summary>
/// <remarks>
/// These tests are skipped on Windows because CliWrap's graceful cancellation uses GenerateConsoleCtrlEvent,
/// which doesn't work reliably for child processes with their own console.
/// See: https://github.com/Tyrrrz/CliWrap/issues/47
/// </remarks>
[ExcludeOn(OS.Windows)]
public class ExternalCancellationTests(TestMode testMode) : InvokableTestBase(testMode)
{
private static readonly string TempPath = Path.GetTempPath();
Expand Down
Loading