chore: centralize environment variable constants (#4882)#4909
Merged
Conversation
Replace scattered environment variable magic strings across TUnit.Engine with references to a new EnvironmentConstants class, improving maintainability and discoverability.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean, well-executed refactoring. All 15 environment variable constants map exactly to their original string literals, and the new |
This was referenced Feb 22, 2026
Open
This was referenced Feb 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TUnit.Engine/Configuration/EnvironmentConstants.cscontaining all environment variable names used across the engine asconst stringfieldsCloses #4882
Test plan
dotnet build TUnit.Engine/TUnit.Engine.csprojpasses across all target frameworks (net8.0, net9.0, net10.0, netstandard2.0) with zero warnings and zero errors