Conversation
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit.Assertions.FSharp 1.17.36 → 1.17.54
This is a Renovate Bot dependency update PR. The change is straightforward and mostly looks good, but there is one architectural concern worth flagging.
Observation: Version Skew Between TUnit Family Packages
After this PR merges, TUnit.Assertions.FSharp will be at 1.17.54 while the rest of the TUnit package family (TUnit, TUnit.Core, TUnit.Engine, TUnit.Assertions, TUnit.AspNetCore) remain at 1.17.36 in Directory.Packages.props:
<PackageVersion Include="TUnit.Assertions.FSharp" Version="1.17.54" /> <!-- updated -->
<PackageVersion Include="TUnit" Version="1.17.36" /> <!-- still old -->
<PackageVersion Include="TUnit.AspNetCore" Version="1.17.36" />
<PackageVersion Include="TUnit.Core" Version="1.17.36" />
<PackageVersion Include="TUnit.Engine" Version="1.17.36" />
<PackageVersion Include="TUnit.Assertions" Version="1.17.36" />TUnit.Assertions.FSharp wraps the core TUnit assertion engine, so a 18-patch-version gap (1.17.36 → 1.17.54) between it and its underlying dependencies could surface API compatibility issues at runtime — particularly given the release notes show a new assertion method (IsAssignableFrom<T>()) added during this window.
Since this repo is TUnit itself, these TUnit packages are the internally-developed ones — it's likely intentional that the external FSharp bindings package tracks ahead. But it's worth verifying the TUnit version constraints in TUnit.Assertions.FSharp 1.17.54's nuspec to ensure the pinned 1.17.36 versions still satisfy its dependency requirements.
Positive Notes
- All three affected files are updated consistently (central
Directory.Packages.props+ both F# template project files). - Template projects correctly pin explicit versions as expected for standalone template content.
- The update is purely additive (patch releases), reducing risk.
Overall this looks fine to merge assuming the TUnit version skew is intentional and the package dependency bounds have been verified.
2b9456d to
d486364
Compare
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit packages 1.17.36 → 1.17.54
This PR updates all TUnit family packages consistently to 1.17.54.
Previous Concern: Resolved ✓
My prior review flagged a version skew risk where TUnit.Assertions.FSharp was being updated in isolation while the rest of the TUnit family stayed at 1.17.36. This PR resolves that concern — all packages are now being updated together:
<PackageVersion Include="TUnit" Version="1.17.54" />
<PackageVersion Include="TUnit.Core" Version="1.17.54" />
<PackageVersion Include="TUnit.Engine" Version="1.17.54" />
<PackageVersion Include="TUnit.Assertions" Version="1.17.54" />
<PackageVersion Include="TUnit.AspNetCore" Version="1.17.54" />
<PackageVersion Include="TUnit.Assertions.FSharp" Version="1.17.54" />
<PackageVersion Include="TUnit.Playwright" Version="1.17.54" />Assessment
- Version consistency: All TUnit packages move in lockstep to the same version — no cross-version compatibility risk.
- Coverage is complete: Both the central
Directory.Packages.propsand all template project files (TUnit.AspNet,TUnit.AspNet.FSharp,TUnit.FSharp,TUnit.Playwright,TUnit.VB) are updated. - Patch release: Changes between 1.17.36 and 1.17.54 include doc updates, a GitHub reporter newline fix, a template redesign, and new
IsAssignableFrom<T>()/IsNotAssignableFrom<T>()assertions — all non-breaking.
This is a clean, consistent update. No concerns. ✅
d486364 to
ac883d1
Compare
This PR contains the following updates:
1.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.54Release Notes
thomhurst/TUnit (TUnit)
v1.17.54: 1.17.54What's Changed
Other Changes
Dependencies
Full Changelog: v1.17.36...v1.17.54
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.