Skip to content

fix: fall back to Running state for Aspire resources without health checks #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+17 −2
Closed

fix: fall back to Running state for Aspire resources without health checks #5265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e97e945
Initial plan
Copilot Mar 27, 2026
aefdad3
fix: handle Aspire 13.2+ resources without health checks in AllHealth…
Copilot Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions TUnit.Aspire/AspireFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,13 +397,27 @@ private async Task WaitForResourcesWithFailFastAsync(
// Linked CTS lets us cancel the failure watchers once all resources are ready
using var failureCts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);

// When waitForHealthy is true, only wait for resources that actually have health
// checks. Resources without health checks never report as healthy in Aspire 13.2+,
// so we fall back to waiting for Running state for those.
HashSet<string>? healthCheckNames = null;
if (waitForHealthy)
{
var model = app.Services.GetRequiredService<DistributedApplicationModel>();
healthCheckNames = new HashSet<string>(
model.Resources
.Where(r => r.Annotations.OfType<HealthCheckAnnotation>().Any())
.Select(r => r.Name));
}

var targetState = waitForHealthy ? "healthy" : "running";
LogProgress($"Waiting for {resourceNames.Count} resource(s) to become {targetState}: [{string.Join(", ", resourceNames)}]");

// Success path: wait for all resources to reach the desired state
var readyTask = Task.WhenAll(resourceNames.Select(async name =>
{
if (waitForHealthy)
var useHealthy = waitForHealthy && (healthCheckNames?.Contains(name) ?? false);
if (useHealthy)
{
await notificationService.WaitForResourceHealthyAsync(name, cancellationToken);
}
Expand All @@ -412,8 +426,9 @@ private async Task WaitForResourcesWithFailFastAsync(
await notificationService.WaitForResourceAsync(name, KnownResourceStates.Running, cancellationToken);
}

var state = useHealthy ? "healthy" : "running";
readyResources.Add(name);
LogProgress($" Resource '{name}' is {targetState} ({readyResources.Count}/{resourceNames.Count})");
LogProgress($" Resource '{name}' is {state} ({readyResources.Count}/{resourceNames.Count})");
}));

// Fail-fast path: complete as soon as ANY resource enters FailedToStart
Expand Down
Loading