Skip to content

build: turn runtime async off - #7720

Merged
thomhurst merged 1 commit into
mainfrom
runtime-async-off
Nov 11, 2026
Merged

thomhurst merged 1 commit into
mainfrom
runtime-async-off

Conversation

@thomhurst

@thomhurst thomhurst commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Runtime async breaks on Android, iOS, browser etc. (Mono can't run it, dotnet/runtime#109632), so net11.0 goes back to normal state machines.

  • drop runtime-async=on from Directory.Build.props and the speed-comparison project
  • browser smoke test goes back to the default Mono runtime instead of the CoreCLR workaround
  • remove the "Mono and WebAssembly on .NET 11" docs note

Public API snapshots unchanged (ran tests/TUnit.PublicAPI on net11.0). The WASI smoke leg that was dropped in #7705 isn't restored here.

Summary by CodeRabbit

  • Documentation
    • Removed .NET 11 guidance for Mono and WebAssembly, including the startup warning and platform-specific recommendations for Browser, Android, iOS, tvOS, Mac Catalyst, and WASI.
  • Configuration
    • Removed explicit runtime feature settings for .NET 11 and test projects, along with the Browser-specific setting that selected CoreCLR.

Mono cannot run runtime-async methods (dotnet/runtime#109632), so the net11.0 assemblies broke on Android, iOS, browser and other Mono targets.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T12:12:54.071104Z 7d2cd2e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes remove runtime-async=on settings from shared build props and UnifiedTests. They also remove the Browser-specific CoreCLR override and the .NET 11 Mono and WebAssembly installation guidance.

Changes: .NET 11 runtime settings

Layer / File(s) Summary
Remove runtime-async settings
Directory.Build.props, tools/speed-comparison/UnifiedTests/UnifiedTests.csproj
Both project configurations no longer enable runtime-async=on.
Remove platform-specific settings and guidance
tests/TUnit.PlatformSmoke/TUnit.PlatformSmoke.csproj, docs/docs/getting-started/installation.md
The Browser-specific UseMonoRuntime=false setting and .NET 11 Mono and WebAssembly guidance were removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • thomhurst/TUnit#7705: Introduced the runtime-async=on setting, Mono limitation guidance, and Browser CoreCLR workaround that this PR removes.
Merge Risk: Minimal · up to 7d2cd

This change turns off runtime-async for net11.0 builds so Mono-based targets such as Android, iOS and Browser can run again. It also removes the matching workaround and documentation. I found no concrete merge-blocking risk in the supplied changes.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: disabling runtime async in the build configuration.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the runtime flags,
Then hops past Browser-specific tags.
The Mono notes are tucked away,
No extra feature switch today.
With docs and props now pared down neat,
The rabbit thumps a cheerful beat.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de5e3b46-44b2-4489-8658-ce09ce414188
Commits

Reviewing files that changed from the base of the PR and between d63bf6d and 7d2cd2e.

Files selected for processing: 4

  • Directory.Build.props
  • docs/docs/getting-started/installation.md
  • tests/TUnit.PlatformSmoke/TUnit.PlatformSmoke.csproj
  • tools/speed-comparison/UnifiedTests/UnifiedTests.csproj
Files with no reviewable changes: 4

  • tools/speed-comparison/UnifiedTests/UnifiedTests.csproj
  • tests/TUnit.PlatformSmoke/TUnit.PlatformSmoke.csproj
  • docs/docs/getting-started/installation.md
  • Directory.Build.props

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

Review: LGTM. This is a clean, minimal revert. It removes runtime-async=on from Directory.Build.props and the speed-comparison project, drops the browser smoke UseMonoRuntime=false workaround, and removes the now-inaccurate docs section. A grep of the PR head found no leftover references to runtime-async, UseMonoRuntime or dotnet/runtime#109632. Note that .mcp.json was unreadable to the grep, so it wasn't checked.

The rationale is sound: Mono can't run runtime-async, so the change fixes Android, iOS and browser targets. Public API snapshots are unchanged, as expected, because the compiler feature doesn't alter the public surface.

One optional follow-up: if you want runtime-async back later, a per-TFM opt-in that excludes Mono-capable consumers would be safer than turning it on globally. That isn't needed here.

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Turns off Runtime Async for net11.0 builds so async methods use compiler-generated state machines.

  • TUnit’s .NET 11 builds use the usual async state machines again.

No actionable issues were found. Builds and browser tests were not run.

Reviews (1) · Last reviewed commit: "build: turn runtime async off" · Reviewed by Greptile

@thomhurst
thomhurst enabled auto-merge (squash) November 11, 2026 12:22
@thomhurst
thomhurst merged commit 522ca7c into main Nov 11, 2026
30 of 31 checks passed
@thomhurst
thomhurst deleted the runtime-async-off branch November 11, 2026 12:36
This was referenced Nov 13, 2026

This branch was previously deployed

1 inactive deployment
Pull Requests — 7d2cd2e9 Deployed Nov 11, 2026 by thomhurst via modularpipeline (ubuntu-latest) #21583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant