Repository navigation
build: turn runtime async off - #7720
Conversation
Mono cannot run runtime-async methods (dotnet/runtime#109632), so the net11.0 assemblies broke on Android, iOS, browser and other Mono targets.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Review: LGTM. This is a clean, minimal revert. It removes The rationale is sound: Mono can't run runtime-async, so the change fixes Android, iOS and browser targets. Public API snapshots are unchanged, as expected, because the compiler feature doesn't alter the public surface. One optional follow-up: if you want runtime-async back later, a per-TFM opt-in that excludes Mono-capable consumers would be safer than turning it on globally. That isn't needed here. |
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryTurns off Runtime Async for
No actionable issues were found. Builds and browser tests were not run. Reviews (1) · Last reviewed commit: "build: turn runtime async off" · Reviewed by Greptile |
Runtime async breaks on Android, iOS, browser etc. (Mono can't run it, dotnet/runtime#109632), so net11.0 goes back to normal state machines.
runtime-async=onfromDirectory.Build.propsand the speed-comparison projectPublic API snapshots unchanged (ran
tests/TUnit.PublicAPIon net11.0). The WASI smoke leg that was dropped in #7705 isn't restored here.Summary by CodeRabbit