remove password field from Extending Administrate Section

[ewertoncodes]

Remove password field from Extending Administrate section. Because password field already exist in the gem administrate.

[ewertoncodes]

that PR makes sense? @pablobm

[getaaron]

I think the belongs_to_search could also be removed?

[pablobm]

Hello @ewertoncodes, and thank you for the PR. Apologies for the delay.

I think the change makes sense, although it would need to also change the phrasing in the sentence right before the list, as these are not the "most popular ones" any more, but rather a hand picked selection. (See my suggestion).

Perhaps also add a new fifth one, like the jsonb plugin?

Regarding @getaaron's suggestion, I'm not sure it's the same, as the belongs_to_search plugin is different from the built-in belongs_to field. However the plugin is quite tricky to use (or was last time I checked) so perhaps it's worth removing it too.

Thoughts?

[ewertoncodes]

@pablobm and @nickcharlton. Looks like the circle ci needs an update on line:

https://github.com/thoughtbot/administrate/blob/main/.circleci/config.yml#L10.
Can I solve that in this PR?

[pablobm]

@ewertoncodes - I just fixed the CI: it required upgrading Rails. Could you please rebase now and I'll merge?

[ewertoncodes]

PR updated

[pablobm]

Merged! Thank you @ewertoncodes 🙂