Handle Selenium "options" deprecation #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2022
Merged
jordan-brough
force-pushed
the
selenium-options-deprecation
branch
from
dbfcc57 to
6bba8d0
Compare
Silences this warning while running "bundle exec rspec":
WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for
driver initialization is deprecated. Use :capabilities with an Array of
value capabilities/options if necessary instead.
jordan-brough
force-pushed
the
selenium-options-deprecation
branch
from
6bba8d0 to
825139b
Compare
Contributor
Author
|
@nickcharlton thanks for merging #2124! I've rebased this on latest I see you also merged #2064 (cc @pablobm). This PR is another way to avoid the warnings, while still maintaining the perhaps "nicer"(?) api for configuring the options. I don't think there's anything different other than the syntax, so feel free to close this PR if you want to just stick with what's in |
Member
|
I think on balance, I prefer the way this looks and I often find I (and presumably others) copy out the config so if we've got a better option I'm going to go with it! Thanks! |
shadoath
pushed a commit
to rinsed-org/administrate
that referenced
this pull request
Mar 11, 2025
Silences this warning while running "bundle exec rspec":
WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for
driver initialization is deprecated. Use :capabilities with an Array of
value capabilities/options if necessary instead.
But with a cleaner approach from that introduced in thoughtbot#2064.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silences this warning while running "bundle exec rspec":