Skip to content

Conversation

@jordan-brough
Copy link
Contributor

@jordan-brough jordan-brough commented Jan 20, 2022

The tests weren't actually running for Rails >= v6. Only the "bundler:audit" task was.

E.g. see the output and the test time (only 3s) in this CircleCI run:

image

See also the bundle exec appraisal rake part of that same test run. The tests only ran for Rails < v6.

The tests weren't actually running, only the "bundler:audit" task was.
@jordan-brough
Copy link
Contributor Author

jordan-brough commented Jan 21, 2022

@pablobm @nickcharlton (I'm not 100% who the maintainers are currently) - I know I've opened a lot of PRs recently, but I think this one is probably the most important one. If you have a minute to take a look sometime that would be great. Thanks! 🙏

@pablobm pablobm merged commit be688bc into thoughtbot:main Jan 24, 2022
@pablobm
Copy link
Collaborator

pablobm commented Jan 24, 2022

@jordan-brough - Thank you so much for all the PRs. Tiny and focused; the best sort of PR! The only reason I'm not merging everything just yet is because I'm having an issue running my specs locally, and it makes it difficult to check things. As soon as I solve this, I'll go through all of them.

I'm going to make an exception with this one and merge it now because as you say it's pretty important (and also embarrassing!).

@jordan-brough
Copy link
Contributor Author

jordan-brough commented Jan 24, 2022

Thanks @pablobm! FYI I'm going to go through and rebase all my PRs on main so that they retrigger tests w/ this update in place.

@jordan-brough jordan-brough deleted the circle-rspec-fix branch January 24, 2022 12:40
@jordan-brough
Copy link
Contributor Author

@pablobm FYI I've rebased them all and they're all green.

Though a couple (2127 and 2128) had some test-flakiness that I don't think is related to the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants