Titleize the column not the user defined locale #2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edivandecastro
approved these changes
Oct 25, 2022
Collaborator
|
I agree that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2014
Ran into this problem when I wanted to render a column with ID in the name. Assumed defining the label in a locale would resolve the issue but no joy.
Overriding a template to display a user defined locale seemed like overkill when it appears that
titleizeis incorrectly applied for the collection partial. Existing usage in other partials/templates is totitleizethe column rather than the result of translate.https://github.com/thoughtbot/administrate/blob/main/app/views/administrate/application/new.html.erb#L19
https://github.com/thoughtbot/administrate/blob/main/app/views/fields/has_one/_form.html.erb#L21
https://github.com/thoughtbot/administrate/blob/main/app/views/fields/has_one/_show.html.erb#L32