Skip to content

Reduce iterations and allocations for Namespace#routes #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablobm merged 2 commits into from
Jan 24, 2025
Merged

Reduce iterations and allocations for Namespace#routes #2440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31b60e6
Reduce iterations of `Namespace#routes`
enviable Sep 27, 2023
e036b6d
Fix standardrb linting
nickcharlton Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/administrate/namespace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,16 @@ def resources
end

def routes
@routes ||= all_routes.select do |controller, _action|
controller.starts_with?("#{namespace}/")
end.map do |controller, action|
[controller.gsub(/^#{namespace}\//, ""), action]
@routes ||= begin
prefix = "#{namespace}/".freeze
Rails.application.routes.routes.filter_map do |route|
next unless route.defaults[:controller]&.start_with?(prefix)

[
route.defaults[:controller].delete_prefix(prefix),
route.defaults[:action]
]
end
end
end

Expand All @@ -25,11 +31,5 @@ def resources_with_index_route
private

attr_reader :namespace

def all_routes
Rails.application.routes.routes.map do |route|
route.defaults.values_at(:controller, :action).map(&:to_s)
end
end
end
end