Skip to content

Conversation

@pablobm
Copy link
Collaborator

@pablobm pablobm commented Jan 24, 2025

After merging #2440, I saw strange CI failures. Looking into it, they don't appear to be related to the PR, but I can't really explain them.

One is related to Ruby 3.3. For some reason, a transitive dependency that wasn't necessary before is needed now? And running bundle update net-smtp simply added it? Beats me.

The other was an issue with Rails 6.x. Looking it up, I found this discussion at StackOverflow. Requiring logger at the right place appears to fix it...?

Additionally, Appraisal seems to be doing something wrong in my computer (tested in macOS) and as a result I can't run some appraisals. See:

$ irb
irb(main):001> require 'mutex_m'
=> true
irb(main):002>

$ bundle exec appraisal rails80 irb
>> BUNDLE_GEMFILE=/Users/pablobm/Documents/personal/administrate/gem/gemfiles/rails80.gemfile bundle exec irb
irb(main):001> require 'mutex_m'
<internal:/Users/pablobm/Documents/personal/laptop/repos/asdf/installs/ruby/3.4.1/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:37:in 'Kernel#require': cannot load such file -- mutex_m (LoadError)
...

Any ideas of what that could be?

@pablobm pablobm force-pushed the missing-dependency branch from c1ce915 to 6af0389 Compare January 24, 2025 17:36
@pablobm pablobm changed the title [WIP] Fix build Fix build Jan 24, 2025
@pablobm pablobm marked this pull request as ready for review January 24, 2025 22:44
@pablobm pablobm requested a review from nickcharlton January 24, 2025 22:44
@nickcharlton
Copy link
Member

Ah, nice. Yeah, I'd been seeing the net-smtp problem on a few things, but couldn't track down what a solution was.

Annoyingly, I can't reproduce the Appraisal issue:

$ be appraisal rails60 irb
>> BUNDLE_GEMFILE=/Users/nickcharlton/projects/thoughtbot/administrate/gemfiles/rails60.gemfile bundle exec irb
irb(main):001>

On Ruby 3.3, it seems like a transitive dependency which wasn't needed
now is. So we add it.
@nickcharlton nickcharlton changed the title Fix build Manually resolve broken net-smtp dependency Jan 29, 2025
@nickcharlton
Copy link
Member

I broke out the logger problem into #2765.

I'm not sure about the Appraisal problem. I've seen a few weird issues now and again, but it's very tricky to get to the bottom of it.

@nickcharlton nickcharlton merged commit 78c0d2e into thoughtbot:main Jan 29, 2025
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants