Allow translations of active record model names in polymorphic dashboard #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Grazie! Do you think you can add that spec then? |
Contributor
Author
|
Hi @pablobm |
Contributor
Author
|
I'll look at the failures in the morning |
heyvaleria
force-pushed
the
allow_translation_polymorophic_dropdown_models
branch
from
e4718e6 to
bc3c1ea
Compare
In polymorphic associations we were not displaying the translations even when present. By replacing to_s with model_name.human we preserve the reference to the activerecord objects, and we are able to show the translated values. Addresses #1994.
nickcharlton
force-pushed
the
allow_translation_polymorophic_dropdown_models
branch
from
bc3c1ea to
beecee1
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1994
In polymorphic associations we were not displaying the translations even when present.
By replacing
to_swithmodel_name.humanwe preserve the reference to the activerecord objects, and we are able to show the translated values.Screenshots
If I remove translations for recipe, we get the model name
Recipewhere above you can seeRicettaI'm gonna see if I can add a spec.
Thanks @pablobm for the recommendation on the method to apply.