Switch to using the feather icon set #2809
Merged
+21
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In implementing #2758, we realised that there's no citation of the source of the icons. It's quite likely that they were custom made at the time, but if they weren't then this was a mistaken license violation. Most practically though, it's a problem when we need to add further icons, as we'd want to use a set which has plenty of options for new features. Feather is a nice set of icons, covering everything we could ever likely need, is MIT licensed and fits well with our current style. This replaces the existing icons in place with the new set, using `currentColor` to provide a path to override the colour in a standard manner (this means that you set the CSS `color` properly and don't need to change `fill` or `stroke`.) https://feathericons.com/ https://github.com/feathericons/feather
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In implementing #2758, we realised that there's no citation of the source of the icons. It's quite likely that they were custom made at the time, but if they weren't then this was a mistaken license violation. Most practically though, it's a problem when we need to add further icons, as we'd want to use a set which has plenty of options for new features.
Feather is a nice set of icons, covering everything we could ever likely need, is MIT licensed and fits well with our current style.
This replaces the existing icons in place with the new set, using
currentColorto provide a path to override the colour in a standard manner (this means that you set the CSScolorproperly and don't need to changefillorstroke.)https://feathericons.com/
https://github.com/feathericons/feather