LDrawLoader: Fix materialLibrary property spelling#2105
Merged
Methuselah96 merged 1 commit intothree-types:masterfrom Apr 3, 2026
Merged
LDrawLoader: Fix materialLibrary property spelling#2105Methuselah96 merged 1 commit intothree-types:masterfrom
Methuselah96 merged 1 commit intothree-types:masterfrom
Conversation
Contributor
|
Thanks! Since it's just a typo that's unlikely to regress, I just left the test changes out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just stumbled across this type mismatch.
https://github.com/mrdoob/three.js/blob/master/examples/jsm/loaders/LDrawLoader.js#L1794
Wasn't really sure on how to properly reflect this change in the tests, so i am very much open for feedback.