Add missing types to UniformNode#2115
Open
shotamatsuda wants to merge 3 commits intothree-types:masterfrom
Open
Add missing types to UniformNode#2115shotamatsuda wants to merge 3 commits intothree-types:masterfrom
shotamatsuda wants to merge 3 commits intothree-types:masterfrom
Conversation
Contributor
Author
|
@Methuselah96 Just to confirm, am I correct that the JSDoc tests are intended to detect suspicious changes and potential incompatibilities made by changes in Three.js, or should I update JSDocs as part of PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing types to UniformNode. They are undocumented but commonly used throughout TSL code in Three.js.
thisas the last parameter of callbacks passed to onUpdate-related functions.