Merged
Conversation
AlaaElattar
reviewed
May 14, 2025
| import 'package:shared_preferences/shared_preferences.dart'; | ||
| import 'package:threebotlogin/helpers/logger.dart'; | ||
|
|
||
| const String _nodeStatusNotificationEnabledKey = |
Contributor
There was a problem hiding this comment.
- The constant is also defined in
background_service.dart, consider keeping it in a shared place.
| crossAxisAlignment: CrossAxisAlignment.stretch, | ||
| children: <Widget>[ | ||
| SwitchListTile( | ||
| title: const Text('Enable node status notifications'), |
Contributor
There was a problem hiding this comment.
maybe we can add info icon or smth like that, shows description of each notification.
| _loadNotificationPreference(); | ||
| } | ||
|
|
||
| void _loadNotificationPreference() async { |
Contributor
There was a problem hiding this comment.
You may consider adding a loading state while fetching the preferences.
| } | ||
|
|
||
| Future<void> checkNodeStatus() async { | ||
| Future<void> checkNodeStatus(String taskId) async { |
Contributor
There was a problem hiding this comment.
As BackgroundFetch.finish(taskId); is called multiple times, it can be added only in finally block.
AlaaElattar
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
#1012
Tested Scenarios