make phone number field editable

[AlaaElattar]

Changes

• make phone number field editable.

Related Issues

• Editable Phone number field > Identity  #763

Tested Scenarios

2024-12-22.15.49.57.mp4

2024-12-22.15.50.41.mp4

2024-12-22.15.51.09.mp4

• Tried to add add phone for the first time and verify it, whatever the phone is verified or not it can be edited easily and then verified again.
• If user tried to update with the same old number, will get an error message.
• Multiple user verify with the same phone number (phone numbers not unique around all users)
• When multiple users verified with the same number, if one of them edit and change his phone number this shouldn't affect the other users phone number which are previously verified.

[AhmedHanafy725]

• Please add edit icon so the user can know that he can edit the phone number
• Prevent using the same old phone number

[zaelgohary]

• Search term color is not compatible with dark theme.

• Search result is not accurate. I tried searching with eg and got the following result.

• Also, notice at the bottom of the page, an overflow happens.

• Padding all should be increased in the dialogue

• While editing the phone, the username and icon shows at the bottom again. Maybe we can check a better UI for this?

[zaelgohary]

As for the overflow, I opened an issue for it here

[zaelgohary]

Suggested change

	'Changing your phone will require you to go through the phone verification process again.',
	'Changing your phone will require re-verification.',

Same with email msg.

Also, can we add more space between the msg & the input? and maybe increase space at the bottom of the cancel btn.

[AlaaElattar]

• All applied except the space under Cancel button, It's a custom dialog used everywhere. They should be all consistent.

[zaelgohary]

• Edited a phone then clicked verify. SMS warning didn't disappear after 2 mins. Notice the time in the screenshots below.

• Also, the phone is not editable if verification is not completed.

[ramezsaeed]

The phone number is unique per app ?
which means can two or more users verify the same number on their apps ?

[AlaaElattar]

• Search term color is not compatible with dark theme.

• Search result is not accurate. I tried searching with eg and got the following result.
• Also, notice at the bottom of the page, an overflow happens.
• Padding all should be increased in the dialogue

• While editing the phone, the username and icon shows at the bottom again. Maybe we can check a better UI for this?

• For the first 2 comments, that's a package already used and i didn't change anything in it I just called the same dialog that was used for adding mobile for the first time.

• For the third comment about username and icon, they're not duplicated, that's the kyc verification.

[AlaaElattar]

• Edited a phone then clicked verify. SMS warning didn't disappear after 2 mins. Notice the time in the screenshots below.

• I changed nothing related to the SMS message flow. There's a separate issue for phone counter to be like the email one.
• I believe this should be fixed there.

[zaelgohary]

• For the first 2 comments, that's a package already used and i didn't change anything in it I just called the same dialog that was used for adding mobile for the first time.

I think we can find a better package for the mobile field. If it is not in this PR, can we open an issue for it?

• For the third comment about username and icon, they're not duplicated, that's the kyc verification.

I understand this is the KYC verification, but the UI feels repetitive. Perhaps we could open an issue to explore a better design? One idea could be removing this section and adding a 'Not verified' label next to the username at the top.

[zaelgohary]

Adding a negative transform to the action buttons and changing the height of the dialogue will fix the spaces issue as shown below.

threefold_connect/app/lib/widgets/phone_widget.dart

Lines 170 to 178 in ef2dcf1

	TextButton(
	child: const Text(
	'Cancel',
	),
	onPressed: () {
	Navigator.pop(context);
	}),
	if (valid)
	TextButton(onPressed: verifyButton, child: const Text('Add'))

          Transform.translate(
            offset: const Offset(0, -20),
            child: 
              Row(children: [

            TextButton(
              child: const Text(
                'Cancel',
              ),
              onPressed: () {
                Navigator.pop(context);
              }),
          if (valid)
            TextButton(onPressed: verifyButton, child: const Text('Add'))
              ],)
          
          ),

[zaelgohary]

I tried verifying with the old phone and no error msg appeared.

[ramezsaeed]

Lets add these test scenarios:

• Verifying with the old phone and error msg should appeared.
• Multiple user verify with the same phone number. (should succeed).
• When multiple users verified with the same number, if one of them edit and change his phone number this shouldn't affect the other users phone number which are previously verified.

[AlaaElattar]

• For the first 2 comments, that's a package already used and i didn't change anything in it I just called the same dialog that was used for adding mobile for the first time.

I think we can find a better package for the mobile field. If it is not in this PR, can we open an issue for it?

• For the third comment about username and icon, they're not duplicated, that's the kyc verification.

I understand this is the KYC verification, but the UI feels repetitive. Perhaps we could open an issue to explore a better design? One idea could be removing this section and adding a 'Not verified' label next to the username at the top.

• Regarding your second comment about the KYC section, it will be removed in another pr.

[AlaaElattar]

Transform.translate(
offset: const Offset(0, -20),
child:
Row(children: [

• Should be fixed
  
  

[zaelgohary]

I still don't see an error message when the old phone number is the same as the new one.

document_6039827747461670918.mp4

[zaelgohary]

I still don't see an error message when the old phone number is the same as the new one.

document_6039827747461670918.mp4

Please disregard this comment; I forgot to pull the latest changes. It's working fine now.