Conversation
Pragma statements are fine to float when a contract is intended for consumption by contracts from another project. This is the case for IApplication and IStaking that are imported from tBTC v2 contracts. If we do not use the floating pragma, all tBTC v2 contracts would need to stay on 0.8.9 and now use the more recent Solidity versions.
nkuba
approved these changes
Sep 28, 2022
70 tasks
nkuba
added a commit
to threshold-network/keep-core
that referenced
this pull request
Sep 28, 2022
Solidity 0.8.17 Depends on threshold-network/solidity-contracts#127 See keep-network/sortition-pools#189 Fix Solidity version on 0.8.17 before the deployment.
This was referenced Sep 28, 2022
nkuba
added a commit
to threshold-network/tbtc-v2
that referenced
this pull request
Sep 28, 2022
Solidity 0.8.17 See keep-network/sortition-pools#189 See threshold-network/solidity-contracts#127 See threshold-network/keep-core#3318 See threshold-network/keep-core#3319 Fix Solidity version on 0.8.17 before the deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pragma statements are fine to float when a contract is intended for consumption by contracts from another project. This is the case for IApplication and IStaking that are imported from tBTC v2 contracts. If we do not use the floating pragma, all tBTC v2 contracts would need to stay on 0.8.9 and now use the more recent Solidity versions.