Skip to content

Editor: MaterialParam leads to shader compilation error #1057 #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eprikazchikov merged 1 commit into from
Aug 13, 2025
Merged

Editor: MaterialParam leads to shader compilation error #1057 #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/editor/shadertools/converter/functions/materialparam.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class ParamFloat : public ShaderNode {
type = link.oport->m_type;
}
static_cast<ShaderGraph *>(m_graph)->addUniform(name().data(), type, m_defaultValue);
stack.push(QString("uni.%1").arg(name().data()));
stack.push(name().data());

return ShaderNode::build(code, stack, link, depth, type);
}
Expand Down Expand Up @@ -71,7 +71,7 @@ class ParamVector : public ShaderNode {
m_defaultValue.y,
m_defaultValue.z,
m_defaultValue.z));
stack.push(QString("uni.%1").arg(name().data()));
stack.push(name().data());

return ShaderNode::build(code, stack, link, depth, type);
}
Expand Down
2 changes: 1 addition & 1 deletion modules/editor/shadertools/converter/shaderbuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ void ShaderBuilder::buildInstanceData(const VariantMap &user, PragmaMap &pragmas
offset++;
}

uniforms += uniform.typeName + " " + uniform.name + " = " + data;
uniforms += TString(" ") + uniform.typeName + " " + uniform.name + " = " + data;
}
}

Expand Down
Loading