Skip to content

Engine: BSD: Address SIGSEGV error Addition#791

Merged
eprikazchikov merged 1 commit intothunder-engine:masterfrom
thearchivalone:te-778_b
Jul 6, 2024
Merged

Engine: BSD: Address SIGSEGV error Addition#791
eprikazchikov merged 1 commit intothunder-engine:masterfrom
thearchivalone:te-778_b

Conversation

@thearchivalone
Copy link
Copy Markdown
Contributor

WeHaveLiveEditor

We have liftoff. The WorldEditor natively works on FreeBSD 14.0. 🥹

@thearchivalone
Copy link
Copy Markdown
Contributor Author

This PR improves #788

@thearchivalone
Copy link
Copy Markdown
Contributor Author

thearchivalone commented Jul 6, 2024

Redoing this real fast on a new branch. Will have it shortly. Rebasing it partially broke my original commit.

@thearchivalone thearchivalone changed the base branch from te-778_b to master July 6, 2024 11:41
@thearchivalone
Copy link
Copy Markdown
Contributor Author

Switching it to master fixed it for me. Sometimes, the compiler on my end will complain about using "widgettool.h" instead of <widgettool.h> for headers that aren't in the same directory as the source but if it keeps playing nice, I won't stress about it. It's a semantics thing. 😄

@thearchivalone
Copy link
Copy Markdown
Contributor Author

If you like this and everything passes, this is ready. Thank you good sir for giving me something to be excited about at work. The fact I barely had to touch your code directly and there wasn't much C++ code that needed to be added to get an initial native build working of your engine and editor, that honestly means you know what you're doing and have designed your tools and system well. I can't wait to dive further into Thunder. I plan to keep contributing and start actually using the tools. <3

@thearchivalone
Copy link
Copy Markdown
Contributor Author

Now comes the fun part: testing, bug fixing and working on getting Qt working locally to make SDK distributing a thing. Getting parity with the other platforms and fixing any performance issues where needed will make the port feel more professional and be more appealing to game developers that want to build on the BSDs. Again, there's not many game dev tools for the platform so this is a pretty big deal for me 🤠

@eprikazchikov
Copy link
Copy Markdown
Collaborator

If you like this and everything passes, this is ready. Thank you good sir for giving me something to be excited about at work. The fact I barely had to touch your code directly and there wasn't much C++ code that needed to be added to get an initial native build working of your engine and editor, that honestly means you know what you're doing and have designed your tools and system well. I can't wait to dive further into Thunder. I plan to keep contributing and start actually using the tools. <3

Thank you!

@eprikazchikov eprikazchikov merged commit 93b156f into thunder-engine:master Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants