Fix: CMake build fixes + Uikit moc header fix#795
Merged
eprikazchikov merged 3 commits intothunder-engine:masterfrom Jul 15, 2024
thearchivalone:fix-moc-freebsd
Merged
Fix: CMake build fixes + Uikit moc header fix#795eprikazchikov merged 3 commits intothunder-engine:masterfrom thearchivalone:fix-moc-freebsd
eprikazchikov merged 3 commits intothunder-engine:masterfrom
thearchivalone:fix-moc-freebsd
Conversation
Contributor
Author
|
This uses a hard coded checkout of my fork and the branch where the code changes were made just to show that it builds properly. If these changes get approved, I'll push a commit that removes that part. There will most likely be a failure to build when I do that but merging the changes into master should fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of putting all of my efforts into ccache right now, I went back to the basics and discovered the root of the Uikit issue: the moc headers list was out of order, causing the failure. This will replace #793