Skip to content

Editor: Graph editor doesn't updating a node titles #861 #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eprikazchikov merged 2 commits into from
Oct 28, 2024
Merged

Editor: Graph editor doesn't updating a node titles #861 #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba76e81
Editor: Graph editor doesn't updating a node titles #861
eprikazchikov Oct 28, 2024
4c57bae
update
eprikazchikov Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/editor/grapheditor/editor/graph/graphnode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ GraphNode::GraphNode() :
m_nodeWidget(nullptr),
m_graph(nullptr) {

connect(this, &GraphNode::objectNameChanged, this, &GraphNode::onNameChanged);
}

GraphNode::~GraphNode() {
Expand Down Expand Up @@ -102,6 +103,12 @@ std::vector<NodePort> &GraphNode::ports() {
return m_ports;
}

void GraphNode::onNameChanged() {
if(m_nodeWidget) {
static_cast<NodeWidget *>(m_nodeWidget)->updateName();
}
}

void GraphNode::saveUserData(QVariantMap &data) {
const QMetaObject *meta = metaObject();
for(int i = 0; i < meta->propertyCount(); i++) {
Expand Down
3 changes: 3 additions & 0 deletions modules/editor/grapheditor/editor/graph/graphnode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ class NODEGRAPH_EXPORT GraphNode : public QObject {
signals:
void updated();

protected:
void onNameChanged();

protected:
std::vector<NodePort> m_ports;

Expand Down
13 changes: 9 additions & 4 deletions modules/editor/grapheditor/editor/graph/graphwidgets/nodewidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,8 @@ NodeWidget::NodeWidget() :

void NodeWidget::setGraphNode(GraphNode *node) {
m_node = node;
if(m_label) {
std::string title = !m_node->objectName().isEmpty() ? qPrintable(m_node->objectName()) : m_node->typeName();
m_label->setText(title);
}

updateName();

if(m_title) {
m_title->setColor(m_node->color());
Expand Down Expand Up @@ -87,6 +85,13 @@ void NodeWidget::setGraphNode(GraphNode *node) {
rect->setSize(size);
}

void NodeWidget::updateName() {
if(m_label) {
std::string title = !m_node->objectName().isEmpty() ? qPrintable(m_node->objectName()) : m_node->typeName();
m_label->setText(title);
}
}

void NodeWidget::setSelected(bool flag) {
if(flag) {
setBorderColor(Vector4(1.0f));
Expand Down
2 changes: 2 additions & 0 deletions modules/editor/grapheditor/editor/graph/graphwidgets/nodewidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ class NodeWidget : public Frame {

void setGraphNode(GraphNode *node);

void updateName();

void setSelected(bool flag);

Frame *title() const;
Expand Down
4 changes: 0 additions & 4 deletions modules/editor/grapheditor/editor/graph/nodegroup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ QString NodeGroup::text() const {
}
void NodeGroup::setText(const QString &text) {
setObjectName(text);

if(m_nodeWidget) {
static_cast<GroupWidget *>(m_nodeWidget)->label()->setText(text.toStdString());
}
}

QColor NodeGroup::groupColor() const {
Expand Down