Move JavaScript SDKs out of the monorepo#3456
Merged
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 298 files, which is 148 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (298)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle ReportChanges will decrease total bundle size by 21.07kB (-0.08%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gate-esmAssets Changed:
view changes for bundle: console-esmAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
savindi7
approved these changes
Jun 22, 2026
savindi7
approved these changes
Jun 22, 2026
Malith-19
added a commit
to Malith-19/thunder
that referenced
this pull request
Jun 23, 2026
Browser SPAs cannot initiate a sign-in flow directly via POST /flow/execute; they must use the redirect-based authorization_code + PKCE flow. Document this in the SDK overview pages and the react-vanilla sample. - Add callouts to the javascript, browser, react and vue SDK overview docs. - Add a notice to the react-vanilla sample steering browser SPAs to the redirect-based react-sdk-sample. The SDK code change lives in thunder-id/javascript-sdks (the SDKs were moved out of this repo in thunder-id#3456). Refs thunder-id#3217 Refs thunder-id#3219
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Extracts the JavaScript SDK packages from the product monorepo into a standalone repository (
sdks/javascript-sdks), aligning with the existing pattern used by the iOS, Android, and Flutter SDKs.Previously, the 10 JS SDK packages (
browser,express,javascript,nextjs,node,nuxt,react,react-router,tanstack-router,vue) lived underproduct/sdks/as part of the product pnpm workspace. This made SDK development, versioning, and release tightly coupled to the product release cycle.Approach
sdks/javascript-sdks/packages/in the standalone SDK repositorysdks/javascript-sdksas an independent pnpm workspace with its ownpnpm-workspace.yaml, rootpackage.json(nx-based build scripts), andnx.json.github/workflows/pr-builder.yml(build, format check, lint, test on PR) and.github/workflows/release.yaml(DAG-ordered manual npm release matching the SDK dependency graph) to the SDK repoworkspace:^references to@thunderid/reactand@thunderid/react-routerwithcatalog:entries so the product consumes published SDK versions rather than local workspace links../sdks/javascript-sdks/**workspace link, therelease-sdks.ymlworkflow, therelease-sdkcomposite action, all SDK-specific catalog entries (buffer,jose,crypto-browserify, etc.), and thebuild_sdks/test_sdks/lint_sdksfunctions frombuild.shRelated Issues
thunder-id/javascript-sdks#3445Related PRs
thunder-id/javascript-sdksjavascript-sdks#1Checklist
breaking changelabel added.Security checks