feat(message-list): migrate MessageListFragment to Compose-based renderer#10785
Open
rafaeltonholo wants to merge 14 commits intothunderbird:mainfrom
Open
feat(message-list): migrate MessageListFragment to Compose-based renderer#10785rafaeltonholo wants to merge 14 commits intothunderbird:mainfrom
rafaeltonholo wants to merge 14 commits intothunderbird:mainfrom
Conversation
… available on state
…ComposeView and FAB
…ompose-based renderer
…parate Koin module
…adiness in WarmingUp state
…simplify MessageListState.WarmingUp logic
…transaction history dump
…older loading and dependency injections - Added `FolderEvent.FolderLoaded` processing to state machine tests. - Updated `MessageListMetadata` assertions to verify folder state. - Injected `TestLogger`, `TestClock`, and `FakeDebuggingSettingsPreferenceManager` into the state machine. - Added `createFolder` and `FakeDebuggingSettingsPreferenceManager` helper classes for testing.
Updated `FeatureMessageListModuleKtTest` to include `Clock` and `DebuggingSettingsPreferenceManager` in the Koin module verification.
…tScreenRendererTest
Contributor
|
Missing report label. Set exactly one of: |
github-actions
bot
added
the
tb-team
rafaeltonholo
added
the
report: exclude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10774.
feature-flag:
enable_message_list_new_stateSummary
MessageListFragmentfrom legacy XML rendering to useMessageListScreenRendererbacked by Composenew_message_list_fragment.xmllayout withComposeViewand FABMessageListScreenRendererinFeatureMessageListModuleMessageListSideEffectsModuleAllConfigurationsReadySideEffectto handle readiness transitions inWarmingUpstateisReadyproperty toMessageListMetadatato simplify state logicMessageListStateMachinewith logging and transaction history dumpMessageListFragmentfrom legacy rendering codeNote
It is expected to see an empty screen when the feature flag is enabled for now. The data load is expected to be implemented in #10775.
Test plan
AllConfigurationsReadySideEffectTestpassesMessageListStateMachineTestpassesMessageListFragmentrenders via Compose (feature flag on)