Skip to content

Changed some calendar names to represent country names#1130

Open
aho15 wants to merge 2 commits intothunderbird:masterfrom
aho15:fix/holiday-calendar-inconsistency-issue-884
Open

Changed some calendar names to represent country names#1130
aho15 wants to merge 2 commits intothunderbird:masterfrom
aho15:fix/holiday-calendar-inconsistency-issue-884

Conversation

@aho15
Copy link
Copy Markdown

@aho15 aho15 commented Feb 19, 2026

Corresponding issue: #884
Changed calendar names to the respective country name instead of language in settings.py.

Unfortunately, due to free tier limitation, I am not able to update all calendars.
This should be done as they currently contain holidays from 2025 - 2028 instead of from 2026 - 2029 and they seem to have been last updated in 04/2025.

Copy link
Copy Markdown
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the potential to result in broken links for consumers — who would have to figure out something's wrong with their ics subscription, come back to the site, and subscribe to the correct file now… so I figure the actual tricky part of the ticket for any renaming really is the necessary addition of all the old-to-new redirects in some place as .htaccess (or its build script)…

settings.py Outdated
Comment on lines 634 to 641
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is whether to also not stop turning the country names into the adjectives here in the "normalization" phase… ("Italian", "French", "German" etc. above too — as not just the calendar names earlier, but also this mapping step changes the end result too…)

filename

@aho15
Copy link
Copy Markdown
Author

aho15 commented Feb 23, 2026

I am sorry for costing your time. I should have seen both of these issues and at least bring them up to you.

Concerning the mapping of the filenames: I removed the entries which only led to change from country name to language. I then recognized for Algeria, it's default language was french, which made me think: why not including the default languages names in the file name as well? I think it won't hurt further and increases consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants