Add source mime type to picture high res helper#958
Open
janbrasna wants to merge 1 commit intothunderbird:masterfrom
Open
Add source mime type to picture high res helper#958janbrasna wants to merge 1 commit intothunderbird:masterfrom
janbrasna wants to merge 1 commit intothunderbird:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #842
This fixes AVIF/WebP compatibility issues in older browsers.
(NB: The simplified idea is to take the alt format as currently provided, used as file extension, and blindly invent "image/[format]" type attribute. This currently works for both "webp" and "avif" types, and if a future "quux" format with ".quux" extension is added it would work too if its mime type would be "image/quux" — however would produce nonsense if its mime was supposed to be "application/quux" or "image/quux+xml", or its extension would differ, e.g. ".quu"… — That said, e.g. "svg" would produce a dubious mime type here; but a vector should not be really used in the high res helper per se anyways…)