Repository navigation
Conversation
|
Thanks for opening your first pull request in the Codna CLI! Please make sure the checks are green and that the change follows CONTRIBUTING.md. A maintainer will review it shortly. |
![codna-ai[bot]](https://avatars.githubusercontent.com/in/4061960?s=60&v=4){kind=small}
| assert wrapper.is_file(), f"missing {wrapper}" | ||
| assert plugin.is_file(), f"missing {plugin}" | ||
| assert "singleSdkCopyPlugin" in wrapper.read_text(encoding="utf-8") | ||
| plugin_source = plugin.read_text(encoding="utf-8") | ||
| # The collapse list is the measured pair, and a bare specifier is what gets rewritten. | ||
| assert '"llms"' in plugin_source and '"shared"' in plugin_source | ||
| assert "packages" in plugin_source and '"src"' in plugin_source |
There was a problem hiding this comment.
🔴 HIGH · correctness — New test asserts files and strings that do not exist in the repo
test_sidecar_build_collapses_duplicate_sdk_copies_and_minifies asserts that scripts/build_agent_core_bundle.ts and scripts/single_sdk_copy.ts exist as files (lines 185-186), that build_cli_release_dist.py contains the strings "build_agent_core_bundle.ts", '"--cline-root"', '"--entry"', and '"--compile", "--minify"' (lines 177-181), and that the plugin source contains '"llms"', '"shared"', 'packages', and '"src"' (lines 190-191). A codebase-wide search across 649 files finds none of these strings or files anywhere outside the test itself. The test will unconditionally fail on the very first assertion (line 177) the moment it is executed, because the sibling scripts it pins were never committed in this PR.
Reply @codna fix and Codna opens a verified, test-green, risk-gated fix PR.
Automated mirror of cli/ (flattened), the root allowlist (server.json, glama.json, LICENSE, .gitleaks.toml) and the public-root/ community tree from thyn-ai/codna at 704e253867183c20a6bdf1e12607fb5db84199a7. Merges itself via auto-merge once the mirror's required checks (codna review, Analyze (python)) pass and the codna-ai review approves; if a later sync lands first, this PR is closed as superseded -- every sync PR is a full snapshot of the exported surface.