al support cloud storage #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
license-eye has checked 669 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 187 | 1 | 481 | 0 |
Click to see the invalid file list
- internal/cli/serverless/auditlog/ui.go
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
zhangyangyu
reviewed
Aug 25, 2025
zhangyangyu
reviewed
Aug 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds cloud storage support for TiDB Cloud Serverless clusters, enabling audit log storage and backup functionality across multiple cloud providers including S3, GCS, Azure Blob, and Alibaba Cloud OSS.
- Introduces cloud storage models and authentication types for S3, GCS, Azure Blob, and OSS
- Extends audit log configuration to support cloud storage options with rotation settings
- Updates cluster models to remove deprecated usage tracking and refactor high availability types
- Adds support for Alibaba Cloud (Alicloud) private endpoints
Reviewed Changes
Copilot reviewed 86 out of 86 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Various model files | New cloud storage models for S3, GCS, Azure Blob, and OSS with authentication types |
| model_v1beta1_cluster_audit_log_config.go | Extended audit log config with cloud storage and rotation settings |
| model_tidb_cloud_open_apiserverlessv1beta1_cluster.go | Removed usage field and updated high availability type references |
| model_endpoints_private.go | Added Alicloud private endpoint support |
| Various auditlog files | Updated API naming from "Serverless" to "Starter and Essential" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zhangyangyu
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature
ticloud serverless audit-log config updatecommand.Break change
ticloud serverless audit-log configis replaced byticloud serverless audit-log config update.ticloud serverless audit-log describeis replaced byticloud serverless audit-log config describe