Skip to content

Added CheckExternalAddressLength to tidefi pallet.#196

Open
steven-semnet wants to merge 3 commits intodevfrom
steven-add-check-bytes-vector
Open

Added CheckExternalAddressLength to tidefi pallet.#196
steven-semnet wants to merge 3 commits intodevfrom
steven-add-check-bytes-vector

Conversation

@steven-semnet
Copy link
Copy Markdown
Contributor

@steven-semnet steven-semnet commented Aug 19, 2022

No description provided.

@github-actions github-actions bot added the A3-inprogress Pull request is in progress. No review needed at this stage. label Aug 19, 2022
@steven-semnet steven-semnet changed the title Added CheckBytesVectors to tidefi pallet. Added CheckCallLength to tidefi pallet. Aug 24, 2022
@steven-semnet steven-semnet marked this pull request as ready for review August 24, 2022 14:57
@steven-semnet steven-semnet requested a review from lemarier August 24, 2022 14:57
@github-actions github-actions bot added A0-pleasereview Pull request needs code review. and removed A3-inprogress Pull request is in progress. No review needed at this stage. labels Aug 24, 2022
@steven-semnet steven-semnet added C3-medium 📣 Elevates a release containing this PR to "medium priority". B1-releasenotes Changes should be mentioned in the release notes of the next minor version release. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Aug 24, 2022
@steven-semnet steven-semnet changed the title Added CheckCallLength to tidefi pallet. WIP: Added CheckCallLength to tidefi pallet. Aug 24, 2022
@steven-semnet steven-semnet changed the title WIP: Added CheckCallLength to tidefi pallet. Added CheckCallLength to tidefi pallet. Aug 24, 2022
@steven-semnet steven-semnet changed the title Added CheckCallLength to tidefi pallet. Added CheckExternalAddressLength to tidefi pallet. Aug 24, 2022
@steven-semnet steven-semnet added B0-silent Changes should not be mentioned in any release notes C1-low 📌 Does not elevate a release containing this beyond "low priority". and removed B1-releasenotes Changes should be mentioned in the release notes of the next minor version release. C3-medium 📣 Elevates a release containing this PR to "medium priority". labels Aug 24, 2022
lemarier
lemarier suggested changes Sep 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lemarier lemarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

frame/tidefi/src/extensions/check_external_address_length.rs
Comment on lines +80 to +82
currency_id: _,
amount: _,
external_address,
Copy link
Copy Markdown
Contributor

@lemarier lemarier Sep 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
currency_id: _,
amount: _,
external_address,
external_address,
..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lemarier lemarier lemarier requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low 📌 Does not elevate a release containing this beyond "low priority". D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@steven-semnet @lemarier