Deprecate the optional_aes field in Geom/Stat#6400
Open
teunbrand wants to merge 5 commits intotidyverse:mainfrom
Open
Deprecate the optional_aes field in Geom/Stat#6400teunbrand wants to merge 5 commits intotidyverse:mainfrom
optional_aes field in Geom/Stat#6400teunbrand wants to merge 5 commits intotidyverse:mainfrom
Conversation
Member
|
I'm slightly unsure why we need this. Yes, it "simplifies" the class definition, but on the other hand it also removes some self-documenting aspects of it. Do you have other reasons for this beside "we can do without"? |
Collaborator
Author
|
The main reason I'd say is that it is a cause of confusion when learning how to build ggplot2 extensions because it isn't really clear what should go into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6393.
It takes the 'violent' path of deprecating the field.
We can also choose to delay deprecating the field.