Conversation
| const homedir = require('os').homedir(); | ||
|
|
||
| // Takes the commit message and runs it through commoji | ||
| const commojiHook = `#!/bin/sh |
There was a problem hiding this comment.
This looks like it wouldn't work if the user isn't at the root of a project.
You might want to use git rev-parse --show-toplevel of $PWD to get the .git directory of a project.
| try { | ||
| // Synchronously test the user's permissions for the file | ||
| // F_OK: Constant for fs.access(). File is visible to the calling process | ||
| fs.accessSync(gitHooksPath, fs.constants.F_OK); |
There was a problem hiding this comment.
I would suggest against checking a fixed path for git templates. Many users reinstall git on macos to update from the built-in version of git.
Instead, running git config --global core.hooksPath without arguments would return a pre-existing hooks path if there is one already defined and used:
There was a problem hiding this comment.
core.hooksPath doesn't exist on certain versions of git, the given gitHooksPath is the default one where hooks are made from what I understood, we can tell the user to specify it.
2 participants
Description
WIP adds
--globaland handles when there is are already precommit/prepare-commit-msg hooks.Motivation and Context
Closes #4 and #5
Types of changes
How Has This Been Tested?
Not yet, just locally
Checklist: